fix(pydantic-ai): Stop emitting duplicate spans - #7056
Open
alexander-alderman-webb wants to merge 5 commits into
Open
fix(pydantic-ai): Stop emitting duplicate spans#7056alexander-alderman-webb wants to merge 5 commits into
alexander-alderman-webb wants to merge 5 commits into
Conversation
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
alexander-alderman-webb
marked this pull request as ready for review
August 6, 2026 08:27
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1e96035. Configure here.
Contributor
Codecov Results 📊✅ 99162 passed | ⏭️ 6479 skipped | Total: 105641 | Pass Rate: 93.87% | Execution Time: 363m 15s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ❌ Patch coverage is 66.67%. Project has 2509 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.95% 89.95% —%
==========================================
Files 193 193 —
Lines 24955 24964 +9
Branches 9004 9008 +4
==========================================
+ Hits 22448 22455 +7
- Misses 2507 2509 +2
- Partials 1437 1437 —Generated by Codecov Action |
sentrivana
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not create a duplicate AI Client span in the cases that
ModelRequestNode.run()orModelRequestNode.stream()hit an early return path in which no model request is made.Replace
len(chat_spans) >= 1withlen(chat_spans) == 1in tests.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)